New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'setAspectRatio(0)' not resetting the default behaviour. #5734

merged 2 commits into from May 30, 2016


None yet
2 participants

danhp commented May 27, 2016

There were 2 things going wrong:

  • We were doing a division by a 0 and it passed on invalid values.
  • There was no way to remove the aspect ratio enforcement once set.

This addresses both of those points.

Closes #5728


This comment has been minimized.


zcbenz commented May 30, 2016


@zcbenz zcbenz merged commit a176aae into electron:master May 30, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@danhp danhp deleted the danhp:fix-aspect-ratio branch Jun 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment