New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support objects with no prototype over IPC #5736

Merged
merged 3 commits into from May 28, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented May 27, 2016

Objects created via Object.create(null) are currently failing to go through rpc-server since hasOwnProperty was being called and is undefined for objects created that way.

It looks like node changed its EventEmitter recently to have the _events property be an object with no prototype so this is pretty easy to reproduce in Electron with:

require('electron').remote.getCurrentWindow()._events

https://github.com/nodejs/node/blob/0c294362502684b9273e7e7c7039ec7028471014/lib/events.js#L9

Closes electron/devtron#73

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented May 28, 2016

👍

@zcbenz zcbenz merged commit 747f910 into master May 28, 2016

9 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3322505 succeeded in 37s
Details
electron-linux-ia32 Build #3322506 succeeded in 33s
Details
electron-linux-x64 Build #3322507 succeeded in 87s
Details
electron-mas-x64 Build #1326 succeeded in 5 min 37 sec
Details
electron-osx-x64 Build #1326 succeeded in 6 min 38 sec
Details
electron-win-ia32 Build #331 succeeded in 5 min 37 sec
Details
electron-win-x64 Build #325 succeeded in 5 min 41 sec
Details

@zcbenz zcbenz deleted the missing-has-own-property branch May 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment