New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add print() to BrowserWindowProxy #5737

Merged
merged 2 commits into from May 27, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented May 27, 2016

Continuation of #5717, adds print support to the BrowserWindowProxy returned from window.open and also available via window.opener in the child window.

/cc @felixrieseberg I made a small tweak to your original PR which was calling print on the BrowserWindow when it needs to instead call it on the webContents.

Closes #5717
Closes #5685

@kevinsawicki kevinsawicki merged commit 1e99f65 into master May 27, 2016

7 of 9 checks passed

electron-osx-x64 Build #1327 failed in 6 min 2 sec
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #3322730 succeeded in 39s
Details
electron-linux-ia32 Build #3322731 succeeded in 35s
Details
electron-linux-x64 Build #3322732 succeeded in 115s
Details
electron-mas-x64 Build #1327 succeeded in 5 min 26 sec
Details
electron-win-ia32 Build #332 succeeded in 6 min 13 sec
Details
electron-win-x64 Build #326 succeeded in 6 min 20 sec
Details
@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented May 27, 2016

Thanks @felixrieseberg 👍

@kevinsawicki kevinsawicki deleted the browser-window-proxy-print branch May 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment