New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep copies of window icons #5782

Merged
merged 1 commit into from May 31, 2016

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented May 31, 2016

Windows doesn't keep copies of the window icons, so after the NativeImage gets garbage collected, the window icon will revert to default when a redrawing happens.

Close #5754.

@zcbenz zcbenz merged commit f5839c3 into master May 31, 2016

9 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3331002 succeeded in 41s
Details
electron-linux-ia32 Build #3331003 succeeded in 36s
Details
electron-linux-x64 Build #3331004 succeeded in 115s
Details
electron-mas-x64 Build #1362 succeeded in 6 min 14 sec
Details
electron-osx-x64 Build #1365 succeeded in 5 min 41 sec
Details
electron-win-ia32 Build #367 succeeded in 6 min 20 sec
Details
electron-win-x64 Build #361 succeeded in 6 min 26 sec
Details

@zcbenz zcbenz deleted the store-icons branch May 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment