New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support array / dictionary types in getUserDefault #5833

Merged
merged 6 commits into from Jun 3, 2016

Conversation

Projects
None yet
2 participants
@CharlieHess
Contributor

CharlieHess commented Jun 2, 2016

Many fields in NSUserDefaults are not primitive types (for example, NSUserDictionaryReplacementItems, NSNavRecentPlaces, etc.); trying to access these using systemPreferences.getUserDefault would just give users undefined. This PR adds support for array and dictionary types.

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jun 3, 2016

👍

@zcbenz zcbenz merged commit f59eecb into electron:master Jun 3, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment