New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support --abi #5911

Merged
merged 1 commit into from Jun 8, 2016

Conversation

Projects
None yet
5 participants
@mafintosh
Contributor

mafintosh commented Jun 7, 2016

this makes it a bit easier to recompile native node modules to your current installed version of electron

npm rebuild --runtime=electron --target=$(electron --version) --disturl=https://atom.io/download/atom-shell --abi=$(electron --abi)
@juliangruber

This comment has been minimized.

Member

juliangruber commented Jun 7, 2016

👍 this is really useful

@paulcbetts

This comment has been minimized.

Contributor

paulcbetts commented Jun 7, 2016

Brilliant!

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Jun 7, 2016

@mafintosh 🆒 would you mind adding this option to usage docs down on line 314?

@mafintosh

This comment has been minimized.

Contributor

mafintosh commented Jun 7, 2016

@kevinsawicki added it to the usage docs

for (let i = 0; i < argv.length; i++) {
if (argv[i] === '--version' || argv[i] === '-v') {
option.version = true
break
else if (argv[i] === '--abi') {

This comment has been minimized.

@danhp

danhp Jun 7, 2016

Member

There's a missing } before the else.

This comment has been minimized.

@mafintosh

mafintosh Jun 8, 2016

Contributor

woops fixed

@mafintosh

This comment has been minimized.

Contributor

mafintosh commented Jun 8, 2016

fixed the comments. any thing else i need to do?

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Jun 8, 2016

fixed the comments. any thing else i need to do?

Looks like there are merge conflicts preventing auto-merging, mind rebasing this branch on master?

@mafintosh

This comment has been minimized.

Contributor

mafintosh commented Jun 8, 2016

@kevinsawicki kevinsawicki merged commit 82bee12 into electron:master Jun 8, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Jun 8, 2016

Awesome, thanks for this 🚢

@mafintosh mafintosh deleted the mafintosh:patch-1 branch Jun 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment