Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disabling Blink features #5923

Merged
merged 10 commits into from Jun 8, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Copy link
Contributor

commented Jun 7, 2016

This pull request adds support for a disableBlinkFeatures option to the BrowserWindow constructor that does the inverse of what the current blinkFeatures option does.

It also adds support for it in <webview> tags using the disableblinkfeatures attribute.

Closes #5460

@@ -938,4 +942,4 @@ All mouse events happened in this window will be passed to the window bellow
this window, but if this window has focus, it will still receive keyboard
events.

[blink-feature-string]: https://code.google.com/p/chromium/codesearch#chromium/src/out/Debug/gen/blink/platform/RuntimeEnabledFeatures.cpp&sq=package:chromium&type=cs&l=576
[blink-feature-string]: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

This comment has been minimized.

Copy link
@zcbenz

zcbenz Jun 8, 2016

Member

❤️

@zcbenz

This comment has been minimized.

Copy link
Member

commented Jun 8, 2016

👍

@zcbenz zcbenz merged commit 6c5eaf6 into master Jun 8, 2016

8 of 9 checks passed

electron-mas-x64 Build #1436 failed in 6 min 24 sec
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3390349 succeeded in 41s
Details
electron-linux-ia32 Build #3390350 succeeded in 35s
Details
electron-linux-x64 Build #3390351 succeeded in 119s
Details
electron-osx-x64 Build #1438 succeeded in 6 min 34 sec
Details
electron-win-ia32 Build #436 succeeded in 6 min 12 sec
Details
electron-win-x64 Build #433 succeeded in 6 min 8 sec
Details

@zcbenz zcbenz deleted the disable-blink-features branch Jun 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.