New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement chrome.i18n.getMessage #5924

Merged
merged 9 commits into from Jun 9, 2016

Conversation

Projects
None yet
3 participants
@kevinsawicki
Contributor

kevinsawicki commented Jun 7, 2016

Initial implementation of chrome.i18n.getMessage

  • Add tests

/cc @jlord 馃崘

Refs #5842

@@ -199,4 +199,6 @@ exports.injectTo = function (extensionId, isBackgroundPage, context) {
setPopup () {},
getPopup () {}
}
chrome.i18n = require('./extensions/i18n.js')

This comment has been minimized.

@kevinsawicki

kevinsawicki Jun 7, 2016

Contributor

@zcbenz Are you okay breaking this out to a separate file so chrome-api doesn't grow too large?

This comment has been minimized.

@zcbenz

zcbenz Jun 8, 2016

Contributor

馃憤

const getExtensionMetadata = () => {
if (!metadata) {
metadata = ipcRenderer.sendSync('CHROME_I18N_MANIFEST', chrome.runtime.id)

This comment has been minimized.

@kevinsawicki

kevinsawicki Jun 7, 2016

Contributor

@zcbenz Any tips for the best way to get the manifest of a devtool's extension from within the extension?

This approach works but not sure if you knew of something cleaner or pre-existing.

This comment has been minimized.

@zcbenz

zcbenz Jun 8, 2016

Contributor

Current solution should be fine, I can't think of a better solution.

@jlord jlord referenced this pull request Jun 8, 2016

Closed

Add `chrome.*` APIs to support Accessibility DevTools extension #5842

16 of 18 tasks complete

@kevinsawicki kevinsawicki changed the title from [WIP] Implement chrome.i18n.getMessage to Implement chrome.i18n.getMessage Jun 9, 2016

jlord and others added some commits Jun 8, 2016

@kevinsawicki kevinsawicki merged commit 50f5025 into master Jun 9, 2016

8 of 9 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #3409058 succeeded in 45s
Details
electron-linux-ia32 Build #3409059 succeeded in 39s
Details
electron-linux-x64 Build #3409060 succeeded in 122s
Details
electron-mas-x64 Build #1476 succeeded in 6 min 55 sec
Details
electron-osx-x64 Build #1482 succeeded in 6 min 30 sec
Details
electron-win-ia32 Build #479 succeeded in 6 min 14 sec
Details
electron-win-x64 Build #473 succeeded in 6 min 6 sec
Details

@kevinsawicki kevinsawicki deleted the chrome-i18n-get-message branch Jun 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment