New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when using fetch in custom protocols #5932

Merged
merged 4 commits into from Jun 8, 2016

Conversation

Projects
None yet
2 participants
@zcbenz
Contributor

zcbenz commented Jun 8, 2016

Close #5855.

zcbenz added some commits Jun 8, 2016

Don't rely on AddAdditionalSchemes for setting standard schemes
On Linux because of the existence of zygote process, it becomes very
tricky to correctly set standard schemes, basically we have to:
1. Pass --standard-schemes to both zygote and render processes
2. Init standard schemes for both zygote and render processes

The )1 is very hard to achieve, so instead of using
AddAdditionalSchemes, we just call url::AddStandardScheme directly.

@zcbenz zcbenz merged commit 3cb5649 into master Jun 8, 2016

8 of 9 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #3392693 succeeded in 41s
Details
electron-linux-ia32 Build #3392694 succeeded in 35s
Details
electron-linux-x64 Build #3392695 succeeded in 121s
Details
electron-mas-x64 Build #1443 succeeded in 5 min 35 sec
Details
electron-osx-x64 Build #1446 succeeded in 5 min 48 sec
Details
electron-win-ia32 Build #443 succeeded in 6 min 18 sec
Details
electron-win-x64 Build #440 succeeded in 6 min 22 sec
Details

@zcbenz zcbenz deleted the fix-standard-scheme branch Jun 8, 2016

@deepak1556

This comment has been minimized.

Member

deepak1556 commented Jun 8, 2016

Awesome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment