New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set maximizable state after installing view #5944

Merged
merged 1 commit into from Jun 9, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Jun 8, 2016

Looks like the call to setWantsLayer on a transparent window with a frame in InstallView was causing the zoom button state to get reset so the previous call to SetMaximizable was getting undone.

This sets the maximizable state after InstallView() is called which appears to resolve this issue.

window = new BrowserWindow({
    show: true,
    width: 800,
    height: 800,
    transparent: true,
    maximizable: false,
    backgroundColor: '#fff',
})

Before

screen shot 2016-06-08 at 2 02 33 pm

### After

screen shot 2016-06-08 at 2 01 14 pm

@zcbenz you mentioned in #5745 (comment) that transparent windows with frames weren't really supported but it might be okay to address if the fix was small and it does seem pretty small, but I'm also fine closing this out if this issue isn't worth addressing.

Closes #5745

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Jun 8, 2016

This does seem to also address the case @danhp mentioned in #5745 (comment) as well:

mainWindow = new BrowserWindow({
  width: 800,
  height: 600,
  titleBarStyle: 'hidden',
  minimizable: false,
  maximizable: false
});

screen shot 2016-06-08 at 2 06 26 pm

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jun 9, 2016

👍

@zcbenz zcbenz merged commit 0abd552 into master Jun 9, 2016

9 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3399769 succeeded in 44s
Details
electron-linux-ia32 Build #3399770 succeeded in 38s
Details
electron-linux-x64 Build #3399771 succeeded in 118s
Details
electron-mas-x64 Build #1453 succeeded in 6 min 4 sec
Details
electron-osx-x64 Build #1457 succeeded in 5 min 47 sec
Details
electron-win-ia32 Build #454 succeeded in 6 min 13 sec
Details
electron-win-x64 Build #451 succeeded in 6 min 16 sec
Details

@zcbenz zcbenz deleted the set-maximizable-last branch Jun 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment