New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default window title to app name #5945

Merged
merged 1 commit into from Jun 9, 2016

Conversation

Projects
None yet
3 participants
@kevinsawicki
Contributor

kevinsawicki commented Jun 8, 2016

Instead of using Electron as the default window title, this pull request uses app.getName() instead which is the name or productName field from the package.json file.

This seems like a more expected default when no <title> element is in the loaded page. 馃憤 / 馃憥 ?

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jun 9, 2016

馃憤

@zcbenz zcbenz merged commit 8a92ee4 into master Jun 9, 2016

9 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3399994 succeeded in 41s
Details
electron-linux-ia32 Build #3399995 succeeded in 35s
Details
electron-linux-x64 Build #3399996 succeeded in 123s
Details
electron-mas-x64 Build #1454 succeeded in 5 min 22 sec
Details
electron-osx-x64 Build #1458 succeeded in 6 min 37 sec
Details
electron-win-ia32 Build #455 succeeded in 6 min 15 sec
Details
electron-win-x64 Build #452 succeeded in 6 min 3 sec
Details

@zcbenz zcbenz deleted the default-title-to-app-name branch Jun 9, 2016

@zeke

This comment has been minimized.

Member

zeke commented Jun 16, 2016

馃槑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment