Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add focusable option #6023

Merged
merged 4 commits into from Jun 13, 2016

Conversation

Projects
None yet
1 participant
@zcbenz
Copy link
Member

commented Jun 13, 2016

This continues the work of #6013:

  • Rename setIgnoreFocus to setFocusable to match other APIs;
  • Add focusable option since it can not be changed dynamically on OS X and Linux;
  • Tunes focusable to make it have less flaws on Windows;
  • Make focusable work on Linux.

@zcbenz zcbenz merged commit 2dc453b into master Jun 13, 2016

8 of 9 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
electron-linux-arm Build #3420843 succeeded in 37s
Details
electron-linux-ia32 Build #3420844 succeeded in 37s
Details
electron-linux-x64 Build #3420845 succeeded in 123s
Details
electron-mas-x64 Build #1511 succeeded in 5 min 43 sec
Details
electron-osx-x64 Build #1516 succeeded in 6 min 49 sec
Details
electron-win-ia32 Build #513 succeeded in 6 min 24 sec
Details
electron-win-x64 Build #506 succeeded in 6 min 12 sec
Details

@zcbenz zcbenz deleted the ignore-focus branch Jun 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.