New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web-contents-created event to app #6029

Merged
merged 4 commits into from Jun 13, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Jun 13, 2016

#5913 added a web-contents-created event to webContents.

This pull request moves the event to app to be consistent with browser-window-created and documents it as a public API.

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jun 13, 2016

👍

@zcbenz zcbenz merged commit af722cc into master Jun 13, 2016

8 of 9 checks passed

electron-win-x64 Build #513 failed in 5 min 59 sec
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3422901 succeeded in 41s
Details
electron-linux-ia32 Build #3422902 succeeded in 35s
Details
electron-linux-x64 Build #3422903 succeeded in 123s
Details
electron-mas-x64 Build #1518 succeeded in 6 min 44 sec
Details
electron-osx-x64 Build #1523 succeeded in 6 min 45 sec
Details
electron-win-ia32 Build #520 succeeded in 6 min 26 sec
Details

@zcbenz zcbenz deleted the web-contents-created-app-api branch Jun 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment