New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add systemPreferences.subscribeLocalNotification #6150

Merged
merged 4 commits into from Jun 21, 2016

Conversation

Projects
None yet
2 participants
@CharlieHess
Contributor

CharlieHess commented Jun 20, 2016

This PR attempts to fix #6066 by adding a subscribeLocalNotification API. The subscription code has been refactored into a helper so both methods can use it.

@CharlieHess

This comment has been minimized.

Contributor

CharlieHess commented Jun 20, 2016

Tower ¯_(ツ)_/¯

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jun 21, 2016

👍

@zcbenz zcbenz merged commit 74321dc into electron:master Jun 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@CharlieHess CharlieHess deleted the CharlieHess:subscribe-local-notification branch Jun 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment