New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quit menu item role #6154

Merged
merged 8 commits into from Jun 21, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Jun 21, 2016

Adds role: 'quit' support to menu items that maps to the terminate selector on OS X and app.quit() on Linux and Windows.

Also does a little var, const, let cleanup and removes CoffeeScript ref variables.

Closes #2813

methodName = rolesMap[this.role]
if (methodInBrowserWindow[methodName]) {
const methodName = rolesMap[this.role]
if(methodInApp[methodName]) {

This comment has been minimized.

@zcbenz

zcbenz Jun 21, 2016

Contributor

Needs a space after if.

@kevinsawicki kevinsawicki merged commit 59ff3dc into master Jun 21, 2016

5 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-osx-x64 Build #1642 in progress...
Details
electron-win-ia32 Build #637 in progress...
Details
electron-linux-arm Build #3492065 succeeded in 40s
Details
electron-linux-ia32 Build #3492066 succeeded in 36s
Details
electron-linux-x64 Build #3492067 succeeded in 124s
Details
electron-mas-x64 Build #1637 succeeded in 5 min 58 sec
Details
electron-win-x64 Build #632 succeeded in 6 min 31 sec
Details

@kevinsawicki kevinsawicki deleted the quit-role branch Jun 21, 2016

Razzeee added a commit to Razzeee/desktop that referenced this pull request Jul 4, 2016

Razzeee added a commit to Razzeee/desktop that referenced this pull request Jul 17, 2016

Razzeee added a commit to Razzeee/desktop that referenced this pull request Jul 17, 2016

Razzeee added a commit to Razzeee/desktop that referenced this pull request Aug 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment