New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add togglefullscreen menu item role #6166

Merged
merged 6 commits into from Jun 22, 2016

Conversation

Projects
None yet
3 participants
@kevinsawicki
Contributor

kevinsawicki commented Jun 21, 2016

Support a role: 'togglefullscreen' that enter/exits full screen mode for the focused window.

Closes #2811

@kevinsawicki kevinsawicki changed the title from Add togglefullscreen role to Add togglefullscreen menu item role Jun 21, 2016

@sindresorhus

This comment has been minimized.

Contributor

sindresorhus commented Jun 21, 2016

On OS X, the label changes from Enter Full Screen to Exit Full Screen when in fullscreen. Not sure whether it should be handled here, but something to keep in mind. These minor details are important for making Electron apps feel native.

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Jun 21, 2016

On OS X, the label changes from Enter Full Screen to Exit Full Screen when in fullscreen. Not sure whether it should be handled here, but something to keep in mind.

It appears to be handled hear automatically, the menu label seems to update correctly with those values once it contains the togglefullscreen role.

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jun 22, 2016

👍

@zcbenz zcbenz merged commit 85c163e into master Jun 22, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3492637 succeeded in 41s
Details
electron-linux-ia32 Build #3492638 succeeded in 37s
Details
electron-linux-x64 Build #3492639 succeeded in 125s
Details
electron-mas-x64 Build #1640 succeeded in 7 min 41 sec
Details
electron-osx-x64 Build #1647 succeeded in 6 min 29 sec
Details
electron-win-ia32 Build #641 succeeded in 6 min 22 sec
Details
electron-win-x64 Build #636 succeeded in 6 min 32 sec
Details

@zcbenz zcbenz deleted the fullscreen-role branch Jun 22, 2016

Razzeee added a commit to Razzeee/desktop that referenced this pull request Jul 4, 2016

Razzeee added a commit to Razzeee/desktop that referenced this pull request Jul 17, 2016

Razzeee added a commit to Razzeee/desktop that referenced this pull request Jul 17, 2016

Razzeee added a commit to Razzeee/desktop that referenced this pull request Aug 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment