New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support forward delete menu item accelerator #6168

Merged
merged 2 commits into from Jun 22, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Jun 21, 2016

Not sure if/when/how this might have regressed, but using an accelerator of Delete no longer works as reported in #5419.

This looks to be because ui::MacKeyCodeForWindowsKeyCode from Chrome is returning NSDeleteFunctionKey as the character instead of NSDeleteCharacter.

From the NSMenuItem keyEquivalent docs:

If you want to specify the Backspace key as the key equivalent for a menu item, use a single character string with NSBackspaceCharacter (defined in NSText.h as 0x08) and for the Forward Delete key, use NSDeleteCharacter (defined in NSText.h as 0x7F). Note that these are not the same characters you get from an NSEvent key-down event when pressing those keys.

https://cs.chromium.org/chromium/src/ui/events/keycodes/keyboard_code_conversion_mac.mm?l=75

This pull request adds a check and mapping for this case which gets Delete working again as an accelerator for a menu like:

{
  label: 'Backspace',
  accelerator: 'Backspace'
},
{
  label: 'Delete',
  accelerator: 'Delete'
}

Before

screen shot 2016-06-21 at 12 31 35 pm

### After

screen shot 2016-06-21 at 12 32 13 pm

Closes #5419

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jun 22, 2016

👍

@zcbenz zcbenz merged commit c0aebc9 into master Jun 22, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3493656 succeeded in 41s
Details
electron-linux-ia32 Build #3493657 succeeded in 36s
Details
electron-linux-x64 Build #3493658 succeeded in 123s
Details
electron-mas-x64 Build #1643 succeeded in 5 min 57 sec
Details
electron-osx-x64 Build #1650 succeeded in 6 min 51 sec
Details
electron-win-ia32 Build #643 succeeded in 6 min 13 sec
Details
electron-win-x64 Build #639 succeeded in 6 min 26 sec
Details

@zcbenz zcbenz deleted the forward-delete branch Jun 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment