New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map roles by command id instead of index #6169

Merged
merged 2 commits into from Jun 22, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Jun 21, 2016

Use GetCommandIdAt to map/retrieve roles since menu indices might change if Menu.insert is used.

Closes #4479

kevinsawicki added some commits Jun 21, 2016

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jun 22, 2016

👍

@zcbenz zcbenz merged commit 4e811fc into master Jun 22, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3495573 succeeded in 43s
Details
electron-linux-ia32 Build #3495574 succeeded in 37s
Details
electron-linux-x64 Build #3495575 succeeded in 124s
Details
electron-mas-x64 Build #1644 succeeded in 5 min 57 sec
Details
electron-osx-x64 Build #1652 succeeded in 6 min 25 sec
Details
electron-win-ia32 Build #645 succeeded in 6 min 27 sec
Details
electron-win-x64 Build #640 succeeded in 6 min 33 sec
Details

@zcbenz zcbenz deleted the map-roles-by-command-id branch Jun 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment