Publish Windows PDBs to allow debugging without Symbol server #6225
Conversation
|
Or is it possible to somehow map the filename to electron.exe? |
|
I believe you can force windbg to load symbol for mismatched name, @paulcbetts should know more. |
Be warned though, that they'll match even if they really shouldn't, and you'll be like me and spend like 30mins wondering why your stack looks so weird because you used 32-bit PDBs with a 64-bit binary |
|
So what's the verdict? Are there any issues with publishing the PDBs except for taking some disk space? |
|
I would be +:100: on this yeah, please do it |
|
@kevinsawicki what do you think about this? |
If publishing these on each release would be helpful to people, I'm totally on board doing it 👍 Just curious, what is the approximate size of this file? |
It's similar to the dSYM zip file size, currently approx 320 MB. |
|
@zcbenz are you ok with this? Would it be possible to get this change into the next release? |
| @@ -152,6 +152,10 @@ def create_symbols(): | |||
| dsyms = glob.glob(os.path.join(OUT_DIR, '*.dSYM')) | |||
| for dsym in dsyms: | |||
| shutil.copytree(dsym, os.path.join(DIST_DIR, os.path.basename(dsym))) | |||
| elif PLATFORM == 'win32': | |||
| pdbs = glob.glob(os.path.join(OUT_DIR, '*.pdb')) | |||
There was a problem hiding this comment.
I was trying this branch locally and the generated pdb zip was empty, looks like OUT_DIR is out/R and the .pdb files are in out/D, am I doing something wrong?
There was a problem hiding this comment.
Nevermind, I hadn't done a full release build locally, only had a debug build in the out/ folder on my Windows VM.
|
🚢 Thanks for this |
I know that you are publishing the electron.exe.pdb and node.dll.pdb to your private symbol server, but when I have a crash dump from an actual rebranded app, then main executable has a different name and cannot be found on the symbol server. I would need to get the electron.exe.pdb and load it manually.