New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nativeImage.createFromPath for non-existent .ico #6278

Merged
merged 3 commits into from Jun 28, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Jun 28, 2016

Continuation of #6254 with added spec. /cc @miniak

Closes #6253
Closes #6254

@kevinsawicki kevinsawicki merged commit 49bec91 into master Jun 28, 2016

7 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #3545111 succeeded in 38s
Details
electron-linux-ia32 Build #3545112 succeeded in 34s
Details
electron-linux-x64 Build #3545113 succeeded in 124s
Details
electron-mas-x64 Build #1736 succeeded in 5 min 46 sec
Details
electron-osx-x64 Build #1742 succeeded in 7 min 6 sec
Details
electron-win-ia32 Build #739 succeeded in 6 min 27 sec
Details
electron-win-x64 Build #729 succeeded in 6 min 39 sec
Details

@kevinsawicki kevinsawicki deleted the ico-native-image-crash branch Jun 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment