New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set window icon before showing window #6323

Merged
merged 1 commit into from Jul 2, 2016

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented Jul 2, 2016

On Linux if we set icon after window shows, weird things will happen.

Close #6205.

@zcbenz zcbenz merged commit 6eda763 into master Jul 2, 2016

7 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #3585025 succeeded in 45s
Details
electron-linux-ia32 Build #3585026 succeeded in 41s
Details
electron-linux-x64 Build #3585027 succeeded in 127s
Details
electron-mas-x64 Build #1763 succeeded in 6 min 5 sec
Details
electron-osx-x64 Build #1771 succeeded in 6 min 35 sec
Details
electron-win-ia32 Build #776 succeeded in 6 min 7 sec
Details
electron-win-x64 Build #764 succeeded in 6 min 20 sec
Details

@zcbenz zcbenz deleted the icon-fix branch Jul 2, 2016

@droghio droghio referenced this pull request Jul 20, 2016

Closed

Add window icon #371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment