New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use require to load package.json #6354

Merged
merged 1 commit into from Jul 6, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Jul 5, 2016

This pull request uses require instead of JSON.parse + fs.readFileSync to load the app's package.json so that a BOM, if included, is stripped.

Closes #6353

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jul 6, 2016

👍

@zcbenz zcbenz merged commit 6fe4653 into master Jul 6, 2016

2 of 7 checks passed

electron-linux-arm Build #3597100 failed in 4s
Details
electron-linux-ia32 Build #3597101 failed in 1s
Details
electron-linux-x64 Build #3597102 failed in 0s
Details
electron-osx-x64 Build #1786 in progress...
Details
electron-win-ia32 Build #791 in progress...
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-win-x64 Build #779 succeeded in 5 min 55 sec
Details

@zcbenz zcbenz deleted the package-json-bom branch Jul 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment