Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle remote arguments with no constructor #6369

Merged
merged 6 commits into from Jul 7, 2016

Conversation

Projects
None yet
3 participants
@kevinsawicki
Copy link
Contributor

kevinsawicki commented Jul 6, 2016

Continuation of #6360 with an added spec.

Use '' as the name when the object argument has no constructor. This makes the behavior for arguments the same as the behavior of return values.

Refs #5736
Closes #6360

@kevinsawicki kevinsawicki force-pushed the remote-object-with-no-constructor branch from d65e3ce to d67dfd0 Jul 6, 2016

@@ -60,7 +60,7 @@ var wrapArgs = function (args, visited) {

ret = {
type: 'object',
name: value.constructor.name,
name: value.constructor != null ? value.constructor.name : 'Object',

This comment has been minimized.

Copy link
@kevinsawicki

kevinsawicki Jul 6, 2016

Author Contributor

@chetverikov I tweaked your change a bit here to return an empty name when constructor.name is empty since that would seem to be the expected behavior for anonymous classes like new (class {}).

@zcbenz

This comment has been minimized.

Copy link
Member

zcbenz commented Jul 7, 2016

👍

@zcbenz zcbenz merged commit 0a64d6e into master Jul 7, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3606485 succeeded in 44s
Details
electron-linux-ia32 Build #3606486 succeeded in 38s
Details
electron-linux-x64 Build #3606487 succeeded in 128s
Details
electron-mas-x64 Build #1795 succeeded in 6 min 4 sec
Details
electron-osx-x64 Build #1806 succeeded in 6 min 46 sec
Details
electron-win-ia32 Build #810 succeeded in 6 min 11 sec
Details
electron-win-x64 Build #798 succeeded in 6 min 18 sec
Details

@zcbenz zcbenz deleted the remote-object-with-no-constructor branch Jul 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.