Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Give menu a chance to handle keydown event before window #6370
Pull request #6068 introduced a regression where menu shortcuts with no modifiers would no longer fire.
This pull request adds back the key forwarding to the main menu before it gets re-dispatched to the window, it was previously done as https://github.com/electron/electron/pull/6068/files#diff-00f46b45a76b7daf5efc593cfbbba7c9L25
This seems like the needed behavior after reading https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/browser_window_utils.mm?l=63