New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give menu a chance to handle keydown event before window #6370

Merged
merged 1 commit into from Jul 7, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Jul 6, 2016

Pull request #6068 introduced a regression where menu shortcuts with no modifiers would no longer fire.

This pull request adds back the key forwarding to the main menu before it gets re-dispatched to the window, it was previously done as https://github.com/electron/electron/pull/6068/files#diff-00f46b45a76b7daf5efc593cfbbba7c9L25

This seems like the needed behavior after reading https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/browser_window_utils.mm?l=63

Closes #6362

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jul 7, 2016

👍

@zcbenz zcbenz merged commit c7e0df0 into master Jul 7, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3602427 succeeded in 40s
Details
electron-linux-ia32 Build #3602428 succeeded in 36s
Details
electron-linux-x64 Build #3602429 succeeded in 127s
Details
electron-mas-x64 Build #1785 succeeded in 6 min 2 sec
Details
electron-osx-x64 Build #1796 succeeded in 6 min 23 sec
Details
electron-win-ia32 Build #800 succeeded in 6 min 9 sec
Details
electron-win-x64 Build #788 succeeded in 6 min 12 sec
Details

@zcbenz zcbenz deleted the send-key-event-to-main-menu branch Jul 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment