Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear protocol handlers on exit #6411

Merged
merged 1 commit into from Jul 9, 2016

Conversation

Projects
None yet
1 participant
@zcbenz
Copy link
Member

zcbenz commented Jul 9, 2016

Close #6388.

This fixes a circular reference problem, the URLRequestContextGetter is referenced by protocol handlers, which are store in AtomURLRequestJobFactory, which the factory is managed by URLRequestContextGetter. So if we do not clear the protocol handlers, the URLRequestContextGetter will never get cleared.

@zcbenz zcbenz merged commit 1beba5b into master Jul 9, 2016

7 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #3626950 succeeded in 46s
Details
electron-linux-ia32 Build #3626951 succeeded in 40s
Details
electron-linux-x64 Build #3626952 succeeded in 76s
Details
electron-mas-x64 Build #1840 succeeded in 5 min 53 sec
Details
electron-osx-x64 Build #1850 succeeded in 7 min 9 sec
Details
electron-win-ia32 Build #850 succeeded in 6 min 20 sec
Details
electron-win-x64 Build #840 succeeded in 6 min 23 sec
Details

@zcbenz zcbenz deleted the clear-protocol-handlers branch Jul 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.