New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add showHiddenFiles property for dialog.showOpenDialog #6431

Merged
merged 4 commits into from Jul 11, 2016

Conversation

Projects
None yet
2 participants
@zcbenz
Contributor

zcbenz commented Jul 11, 2016

Close #3262.

@zcbenz zcbenz merged commit d5a7b3b into master Jul 11, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3628704 succeeded in 43s
Details
electron-linux-ia32 Build #3628705 succeeded in 37s
Details
electron-linux-x64 Build #3628706 succeeded in 73s
Details
electron-mas-x64 Build #1862 succeeded in 6 min 31 sec
Details
electron-osx-x64 Build #1870 succeeded in 6 min 36 sec
Details
electron-win-ia32 Build #871 succeeded in 6 min 24 sec
Details
electron-win-x64 Build #860 succeeded in 6 min 28 sec
Details

@zcbenz zcbenz deleted the show-hidden-files branch Jul 11, 2016

@bpasero

This comment has been minimized.

Contributor

bpasero commented Aug 31, 2016

@zcbenz I am trying to use this property via Electron 1.3.4 and in none of the OS I run (Windows 10, Mac OS X 10.11.6, Ubuntu 15) I am seeing an option in the dialog to show hidden files.

I am using the following properties:

  • Mac: 'multiSelections', 'openDirectory', 'openFile', 'createDirectory', 'showHiddenFiles'
  • Windows/Linux: 'multiSelections', 'openFile', 'createDirectory', 'showHiddenFiles'
@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 31, 2016

@bpasero This option just forces the dialog to show all hidden files, adding a toggle in the dialog would involve much more work than this, since it requires custom view.

@bpasero

This comment has been minimized.

Contributor

bpasero commented Aug 31, 2016

@zcbenz ok got it, I was just looking at the screenshot in #3262 (comment) and was hunting for that toggle, but the way it works now is also perfectly fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment