New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain stack of visited objects for cycle detection #6442

Merged
merged 8 commits into from Jul 12, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Jul 11, 2016

Previously the visited objects array grew for all arguments which would mean circular references could be detected for arrays and objects referenced multiple times but not actually referencing each other in a circular fashion.

Now values are removed from the visited set once they are fully serialized and still null-ed out when a cycle is detected.

Closes #6435

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jul 12, 2016

👍

@zcbenz zcbenz merged commit 21a8a72 into master Jul 12, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3632551 succeeded in 42s
Details
electron-linux-ia32 Build #3632552 succeeded in 37s
Details
electron-linux-x64 Build #3632553 succeeded in 73s
Details
electron-mas-x64 Build #1879 succeeded in 5 min 58 sec
Details
electron-osx-x64 Build #1883 succeeded in 6 min 49 sec
Details
electron-win-ia32 Build #886 succeeded in 6 min 27 sec
Details
electron-win-x64 Build #874 succeeded in 6 min 29 sec
Details

@zcbenz zcbenz deleted the circular-references branch Jul 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment