Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement login item API on Windows #6444

Merged
merged 7 commits into from Jul 12, 2016

Conversation

Projects
None yet
3 participants
@kevinsawicki
Copy link
Contributor

kevinsawicki commented Jul 11, 2016

Implements #6375 on Windows by reading/writing registry keys following https://msdn.microsoft.com/en-us/library/windows/desktop/aa376977(v=vs.85).aspx

This pull request uses the app user model id as the key name, not sure if app.getName() would be a "better" name. /cc @felixrieseberg

@zcbenz

This comment has been minimized.

Copy link
Member

zcbenz commented Jul 12, 2016

👍

@felixrieseberg

This comment has been minimized.

Copy link
Member

felixrieseberg commented Jul 12, 2016

LGTM 🙏

@kevinsawicki kevinsawicki force-pushed the windows-login-items branch from cf681b7 to afd5e51 Jul 12, 2016

@kevinsawicki kevinsawicki merged commit d842604 into master Jul 12, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3640504 succeeded in 50s
Details
electron-linux-ia32 Build #3640505 succeeded in 44s
Details
electron-linux-x64 Build #3640506 succeeded in 79s
Details
electron-mas-x64 Build #1901 succeeded in 6 min 2 sec
Details
electron-osx-x64 Build #1904 succeeded in 5 min 59 sec
Details
electron-win-ia32 Build #905 succeeded in 6 min 26 sec
Details
electron-win-x64 Build #893 succeeded in 6 min 28 sec
Details

@kevinsawicki kevinsawicki deleted the windows-login-items branch Jul 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.