New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroy the native tray in next tick #6448

Merged
merged 1 commit into from Jul 12, 2016

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented Jul 12, 2016

Otherwise when destroying the tray icon from its context menu, crash may happen on older macOS versions.

Close #5656.

@zcbenz zcbenz merged commit 056166e into master Jul 12, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3637189 succeeded in 45s
Details
electron-linux-ia32 Build #3637190 succeeded in 40s
Details
electron-linux-x64 Build #3637191 succeeded in 74s
Details
electron-mas-x64 Build #1894 succeeded in 5 min 51 sec
Details
electron-osx-x64 Build #1898 succeeded in 6 min 46 sec
Details
electron-win-ia32 Build #898 succeeded in 6 min 22 sec
Details
electron-win-x64 Build #887 succeeded in 6 min 4 sec
Details

@zcbenz zcbenz deleted the tray-next-tick branch Jul 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment