New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad options for creating Session #6470

Merged
merged 17 commits into from Jul 14, 2016

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented Jul 13, 2016

This PR adds options to the session.fromPartition(partition[, options]) API, so when the session with the partition has not been created, Electron will use options to create the session. An example of making the default session ignore cache:

session.fromPartition('', { cache: false })

This gives us a way to add options for various networking behaviors, instead of adding global command line switches. Currently there is only cache option in options.

The code of protocol and chrome-extension has been refactored, so Electron won't always create default session automatically on startup, otherwise it won't be possible for users to configure the default session.

Close #1720.

@zcbenz zcbenz merged commit 183b599 into master Jul 14, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3647806 succeeded in 50s
Details
electron-linux-ia32 Build #3647807 succeeded in 43s
Details
electron-linux-x64 Build #3647808 succeeded in 79s
Details
electron-mas-x64 Build #1915 succeeded in 5 min 38 sec
Details
electron-osx-x64 Build #1920 succeeded in 6 min 54 sec
Details
electron-win-ia32 Build #920 succeeded in 6 min 15 sec
Details
electron-win-x64 Build #908 succeeded in 6 min 14 sec
Details

@zcbenz zcbenz deleted the session-options branch Jul 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment