New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detail attributes for certificate-error #6474

Merged
merged 2 commits into from Jul 14, 2016

Conversation

Projects
None yet
4 participants
@darkdh
Contributor

darkdh commented Jul 13, 2016

We can extract more detail from certificate when encountering error.

@zeke

This comment has been minimized.

Member

zeke commented Jul 13, 2016

Started here: brave/muon#25

dict.Set("serialNumber", val->serial_number());
dict.Set("validStart", val->valid_start().ToDoubleT());
dict.Set("validExpiry", val->valid_expiry().ToDoubleT());
dict.Set("fingerprint", net::HashValue(val->fingerprint()).ToString());

This comment has been minimized.

@deepak1556

deepak1556 Jul 13, 2016

Member

fingertprint method is removed in future releases, related CL https://codereview.chromium.org/2000503002

This comment has been minimized.

@darkdh

darkdh Jul 14, 2016

Contributor

It is replaced by CalculateFingerprint256() in 02e89d6

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jul 14, 2016

👍

@zcbenz zcbenz merged commit 3ace677 into electron:master Jul 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@darkdh darkdh deleted the darkdh:cert_detail branch Jul 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment