New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ArrayBuffer.isView to detect Buffer and ArrayBuffer #6590

Merged
merged 4 commits into from Jul 25, 2016

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented Jul 25, 2016

It is better than comparing class names. Refs #6572.

@zcbenz zcbenz merged commit 72c4952 into master Jul 25, 2016

6 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-x64 Build #3693193 queued
Details
electron-linux-arm Build #3693189 succeeded in 45s
Details
electron-linux-ia32 Build #3693190 succeeded in 38s
Details
electron-mas-x64 Build #1990 succeeded in 6 min 2 sec
Details
electron-osx-x64 Build #1988 succeeded in 7 min 2 sec
Details
electron-win-ia32 Build #999 succeeded in 6 min 16 sec
Details
electron-win-x64 Build #980 succeeded in 6 min 29 sec
Details

@zcbenz zcbenz deleted the reliable-typed-array branch Jul 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment