New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window position doesn't restore correctly minimize and restore window #6596

Merged
merged 2 commits into from Jul 26, 2016

Conversation

Projects
None yet
3 participants
@liusy182
Contributor

liusy182 commented Jul 25, 2016

close #6574

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jul 26, 2016

👍

@zcbenz zcbenz merged commit 7b6d74f into electron:master Jul 26, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@simast

This comment has been minimized.

Contributor

simast commented Jul 31, 2016

This change seems to have introduced a regression when BrowserWindow is created with minWidth property. Minimizing and then restoring the window will restore it to a larger width!

@liusy182

This comment has been minimized.

Contributor

liusy182 commented Jul 31, 2016

@simast Thanks for spotting this and sorry for my oversight. I have opened a new PR to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment