New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asar implementation of fs.access/accessSync #6598

Merged
merged 5 commits into from Jul 26, 2016

Conversation

Projects
None yet
3 participants
@kevinsawicki
Contributor

kevinsawicki commented Jul 25, 2016

This pull request patches fs.access and fs.accessSync to support paths in asar archives.

It also does a little 馃帹 on the file and uses let/const instead of var.

It also supports calling fs APIs with a Buffer path (instead of a String) which was added in node 6.0.0, nodejs/node#5616

Closes #6555

@zeke

This comment has been minimized.

Member

zeke commented Jul 25, 2016

Nice. Do you have an immediate use for this?

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Jul 25, 2016

Do you have an immediate use for this?

Nope, just wanted to unblock things like https://github.com/sindresorhus/path-exists/ which was mentioned in #6555

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jul 26, 2016

馃憤

@zcbenz zcbenz merged commit b139d5a into master Jul 26, 2016

7 of 8 checks passed

electron-linux-x64 Build #3696941 failed in 71s
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3696939 succeeded in 43s
Details
electron-linux-ia32 Build #3696940 succeeded in 37s
Details
electron-mas-x64 Build #1993 succeeded in 6 min 29 sec
Details
electron-osx-x64 Build #1993 succeeded in 6 min 51 sec
Details
electron-win-ia32 Build #1002 succeeded in 6 min 19 sec
Details
electron-win-x64 Build #985 succeeded in 6 min 28 sec
Details

@zcbenz zcbenz deleted the fs-access-asar branch Jul 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment