New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all spaces from potential appUserModelID as it isn't allowed by the spec #6602

Merged
merged 2 commits into from Jul 27, 2016

Conversation

Projects
None yet
4 participants
@MarshallOfSound
Member

MarshallOfSound commented Jul 26, 2016

Pairs up with Squirrel/Squirrel.Windows/pull/778

@@ -93,8 +93,8 @@ if (process.platform === 'win32') {
if (fs.statSyncNoException(updateDotExe)) {
var packageDir = path.dirname(path.resolve(updateDotExe))
var packageName = path.basename(packageDir)
var exeName = path.basename(process.execPath).replace(/\.exe$/i, '')
var packageName = path.basename(packageDir).replace(/ /g, '')

This comment has been minimized.

@zeke

zeke Jul 26, 2016

Member

maybe /\s/g would match more space-like characters?

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jul 27, 2016

👍

@zcbenz zcbenz merged commit 1e61743 into master Jul 27, 2016

5 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #2018 succeeded in 6 min 12 sec
Details
electron-osx-x64 Build #2016 succeeded in 6 min 18 sec
Details
electron-win-ia32 Build #1029 succeeded in 6 min 25 sec
Details
electron-win-x64 Build #1016 succeeded in 6 min 33 sec
Details

@zcbenz zcbenz deleted the appusermodelid-remove-spaces branch Jul 27, 2016

@eugirdor

This comment has been minimized.

eugirdor commented Jul 28, 2016

Is this going to cause any issues with auto-updating the app? I know there was a similar change made on macOS for the bundle identifier, and it caused auto-updating to fail because the new app's identifier no longer matched the old one.

@MarshallOfSound

This comment has been minimized.

Member

MarshallOfSound commented Jul 28, 2016

@eugirdor This shouldn't affect auto-updating the app as the appUserModelID is independent of how Squirrel triggers updates.

@eugirdor

This comment has been minimized.

eugirdor commented Jul 28, 2016

@MarshallOfSound Cool, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment