New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only register code range in Windows crash reporter once #6618

Merged
merged 3 commits into from Jul 27, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Jul 26, 2016

Previously, calling RegisterNonABICompliantCodeRange multiple times via crashReporter.start would cause a crash.

This pull request updates it to only be called once instead.

Closes #6550

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jul 27, 2016

👍

@zcbenz zcbenz merged commit 7994f08 into master Jul 27, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3705579 succeeded in 41s
Details
electron-linux-ia32 Build #3705580 succeeded in 37s
Details
electron-linux-x64 Build #3705581 succeeded in 71s
Details
electron-mas-x64 Build #2013 succeeded in 6 min 14 sec
Details
electron-osx-x64 Build #2011 succeeded in 7 min 6 sec
Details
electron-win-ia32 Build #1024 succeeded in 6 min 22 sec
Details
electron-win-x64 Build #1011 succeeded in 6 min 34 sec
Details

@zcbenz zcbenz deleted the code-range-registration branch Jul 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment