New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set download item save path to selected path from dialog #6629

Merged
merged 3 commits into from Jul 28, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Jul 28, 2016

Set the save path of the download item to the path selected from the save dialog so it is accessible once set.

This pull requests also makes the downloadItem.getSavePath() API public.

Closes #5877

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jul 28, 2016

👍

@zcbenz zcbenz merged commit e73bd00 into master Jul 28, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3718088 succeeded in 46s
Details
electron-linux-ia32 Build #3718089 succeeded in 41s
Details
electron-linux-x64 Build #3718090 succeeded in 76s
Details
electron-mas-x64 Build #2032 succeeded in 7 min 19 sec
Details
electron-osx-x64 Build #2029 succeeded in 6 min 45 sec
Details
electron-win-ia32 Build #1044 succeeded in 6 min 42 sec
Details
electron-win-x64 Build #1028 succeeded in 6 min 23 sec
Details

@zcbenz zcbenz deleted the download-item-get-save-path branch Jul 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment