Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that window is an EventDispatchingWindow #6637

Merged
merged 1 commit into from Jul 29, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Copy link
Contributor

kevinsawicki commented Jul 28, 2016

It looks like sometimes the event.os_event.window property is an NSToolbarFullScreenWindow which will crash when redispatch of the key event is attempted.

This pull requests adds an explicit check for the window being an EventDispatchingWindow.

I was unable to actually reproduce #6630 locally, I tried running keyboard commands for full screen windows, with and without frames, and with various title bar styles.

Closes #6630

@zcbenz

This comment has been minimized.

Copy link
Member

zcbenz commented Jul 29, 2016

👍

@zcbenz zcbenz merged commit 72612ed into master Jul 29, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3720874 succeeded in 46s
Details
electron-linux-ia32 Build #3720875 succeeded in 41s
Details
electron-linux-x64 Build #3720876 succeeded in 76s
Details
electron-mas-x64 Build #2035 succeeded in 6 min 53 sec
Details
electron-osx-x64 Build #2032 succeeded in 6 min 25 sec
Details
electron-win-ia32 Build #1047 succeeded in 6 min 27 sec
Details
electron-win-x64 Build #1031 succeeded in 6 min 28 sec
Details

@zcbenz zcbenz deleted the check-window-class branch Jul 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.