New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check view before checking top level native window #6644

Merged
merged 2 commits into from Jul 29, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Jul 28, 2016

Calling web_contents()->GetTopLevelNativeWindow() appears to crash if called when no web_contents()->GetRenderWidgetHostView() is available.

This pull requests tweaks the WebContents::IsFocused method to not check the window's focus state when no render widget host view is present.

Closes #6642

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jul 29, 2016

👍

@zcbenz zcbenz merged commit ea6e6da into master Jul 29, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3724525 succeeded in 52s
Details
electron-linux-ia32 Build #3724526 succeeded in 49s
Details
electron-linux-x64 Build #3724527 succeeded in 80s
Details
electron-mas-x64 Build #2037 succeeded in 5 min 41 sec
Details
electron-osx-x64 Build #2035 succeeded in 6 min 57 sec
Details
electron-win-ia32 Build #1050 succeeded in 6 min 14 sec
Details
electron-win-x64 Build #1033 succeeded in 6 min 29 sec
Details

@zcbenz zcbenz deleted the webcontents-is-focused-crash branch Jul 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment