New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FunctionTemplate instead of ObjectTemplate for native classes #6688

Merged
merged 13 commits into from Aug 2, 2016

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented Aug 2, 2016

This means every native class now gets a constructor, so it is possible for us to manipulate the prototype of native classes directly instead of running hooks for creations of every native object.

@zcbenz zcbenz merged commit 9116939 into master Aug 2, 2016

7 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #3748001 succeeded in 130s
Details
electron-linux-ia32 Build #3748002 succeeded in 52s
Details
electron-linux-x64 Build #3748003 succeeded in 85s
Details
electron-mas-x64 Build #2062 succeeded in 6 min 30 sec
Details
electron-osx-x64 Build #2063 succeeded in 6 min 11 sec
Details
electron-win-ia32 Build #1084 succeeded in 6 min 31 sec
Details
electron-win-x64 Build #1067 succeeded in 6 min 39 sec
Details

@zcbenz zcbenz deleted the constructor-refactor branch Aug 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment