New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offscreen rendering support for Electron #6691

Merged
merged 67 commits into from Aug 3, 2016

Conversation

Projects
None yet
5 participants
@gerhardberger
Member

gerhardberger commented Aug 2, 2016

This PR adds support to render browser windows offscreen in Electron, through a 'paint' event on window.webContents.

We (@brenca and me) implemented a similar approach, than what CEF uses.

It supports two types of offscreen rendering: GPU-accelerated and software-based (which is quite faster), also the frame rate can be adjusted and painting can be controlled.

It depends on a custom brightray fork, which is also submitted as a PR.

@miniak

This comment has been minimized.

Contributor

miniak commented Aug 2, 2016

@gerhardberger I would suggest squashing the commits, 66 is way too many.

@paulcbetts

This comment has been minimized.

Contributor

paulcbetts commented Aug 2, 2016

Please fix the indentation in your files so that you're not rewriting whole files first as well

@gerhardberger

This comment has been minimized.

Member

gerhardberger commented Aug 2, 2016

@paulcbetts thanks, it was a line-endings issue, didn't notice it.

@paulcbetts

This comment has been minimized.

Contributor

paulcbetts commented Aug 2, 2016

@gerhardberger Sorry to lead off my response with a complaint, this is very cool!

@zcbenz zcbenz referenced this pull request Aug 3, 2016

Merged

Merge #6691 #6703

@zcbenz zcbenz merged commit 1663a9c into electron:master Aug 3, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

zcbenz added a commit that referenced this pull request Aug 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment