Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Node's call of SetAutorunMicrotasks(false) #6707

Merged
merged 1 commit into from Aug 3, 2016

Conversation

Projects
None yet
1 participant
@zcbenz
Copy link
Member

zcbenz commented Aug 3, 2016

Close #6605.

The remote devtools of Chrome initializes itself in two steps: 1. Inject runtime bindings; 2. start the application when window is loaded. The step 1 is a chain of Promises, and Chrome assumes all the Promises will get resolved before the window.onload.

However Node turns off the AutorunMicrotasks of V8, making the resolution of Promises to be delayed. So the app of devtools is started before its runtime bindings get ready.

This PR fixes it by reverting Node's call of SetAutorunMicrotasks(false).

@zcbenz zcbenz merged commit 230943d into master Aug 3, 2016

7 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #3758302 succeeded in 50s
Details
electron-linux-ia32 Build #3758303 succeeded in 45s
Details
electron-linux-x64 Build #3758304 succeeded in 80s
Details
electron-mas-x64 Build #2082 succeeded in 5 min 47 sec
Details
electron-osx-x64 Build #2082 succeeded in 6 min 54 sec
Details
electron-win-ia32 Build #1103 succeeded in 6 min 26 sec
Details
electron-win-x64 Build #1087 succeeded in 6 min 36 sec
Details

@zcbenz zcbenz deleted the auto-run-micro-tasks branch Aug 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.