New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocol: custom standard schemes should support cookies #6708

Merged
merged 2 commits into from Aug 5, 2016

Conversation

Projects
None yet
2 participants
@deepak1556
Member

deepak1556 commented Aug 3, 2016

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 4, 2016

How about adding a URLRequestContextGetter::Delegate::GetCookieableSchemes() method, and return the schemes in AtomBrowserContext? The schemes are not passed across processes so we don't need to use command line parameters to pass them.

@deepak1556

This comment has been minimized.

Member

deepak1556 commented Aug 4, 2016

Fixed, Thanks!

zcbenz added a commit that referenced this pull request Aug 5, 2016

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 5, 2016

👍

@zcbenz zcbenz merged commit 6cd1aa2 into electron:master Aug 5, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment