New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a dummy view in the offscreen window #6723

Merged
merged 5 commits into from Aug 4, 2016

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented Aug 4, 2016

This makes sure we have a valid view staying in the window, so opening devtools won't trigger crashes, and the keyboard events can correctly pass in the window.

Refs #6704.

screen shot 2016-08-04 at 4 36 33 pm

zcbenz added some commits Aug 4, 2016

Pass OnPaint callback in constructor
This can catch the paint events happened before onload event.

@zcbenz zcbenz merged commit 7624958 into master Aug 4, 2016

7 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
electron-linux-arm Build #3768495 succeeded in 52s
Details
electron-linux-ia32 Build #3768496 succeeded in 46s
Details
electron-linux-x64 Build #3768497 succeeded in 94s
Details
electron-mas-x64 Build #2089 succeeded in 6 min 44 sec
Details
electron-osx-x64 Build #2087 succeeded in 7 min 55 sec
Details
electron-win-ia32 Build #1109 succeeded in 6 min 32 sec
Details
electron-win-x64 Build #1094 succeeded in 6 min 20 sec
Details

@zcbenz zcbenz deleted the dummy-view branch Aug 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment