New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for transparent frames when offscreen window restarted painting #6737

Merged
merged 1 commit into from Aug 5, 2016

Conversation

Projects
None yet
3 participants
@brenca
Member

brenca commented Aug 5, 2016

We used to call Show and Hide when starting/stopping the flow of painting events - this caused a bug where upon restarting the first frame that was generated was completely transparent in some cases (mostly when pushing the limits of the machine's memory).
Related to #6704.

@enlight

This comment has been minimized.

Contributor

enlight commented Aug 5, 2016

Can you rebase your changes to get rid of the merge commit please?

added checks for painting_ when setting the outputdevice to active st…
…ate and removed show/hide from start/stoppainting since during testing they caused transparent frames to appear when a window was set to paint again after stopping
@brenca

This comment has been minimized.

Member

brenca commented Aug 5, 2016

Sure! Sorry, I need to improve my git skills : )

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 5, 2016

👍

@zcbenz zcbenz merged commit 5eeadb0 into electron:master Aug 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment