Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offscreen rendering fixes for macOS #6741

Merged
merged 3 commits into from Aug 8, 2016

Conversation

Projects
None yet
2 participants
@gerhardberger
Copy link
Member

gerhardberger commented Aug 5, 2016

This PR moves the ui::AcceleratedWidgetMacNSView implementation to NativeWindowMac, so the native window can be used in offscreen mode for accelerated widget, no need for an extra hidden window.

@zcbenz

This comment has been minimized.

Copy link
Member

zcbenz commented Aug 5, 2016

The OffScreenRenderWidgetHostView stores the pointer to NativeWindow, we can probably just cast it to NativeWindowMac* and get its window_ in OffScreenRenderWidgetHostView. I think it is good to keep AcceleratedWidgetMacNSView in offscreen classes..

@brenca brenca force-pushed the MaxWhere:native-window-widget-mac branch from 363c4e6 to f29dc34 Aug 5, 2016

@gerhardberger gerhardberger changed the title Moves AcceleratedWidgetMacNSView to NativeWindowMac Offscreen rendering fixes for macOS Aug 5, 2016

@gerhardberger

This comment has been minimized.

Copy link
Member Author

gerhardberger commented Aug 5, 2016

Added here a solution to another macOS issue, which caused weird behavior after destroying browsers, the last one in #6704

@zcbenz

This comment has been minimized.

Copy link
Member

zcbenz commented Aug 8, 2016

👍

@zcbenz zcbenz merged commit b6becde into electron:master Aug 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.