New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recovery suggestion to auto update failure string #6743

Merged
merged 1 commit into from Aug 8, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Aug 5, 2016

This pull requests adds the auto update error's localizedRecoverySuggestion value to the error message when available.

The message on a non-200 response will now be:

Update check failed. The server sent an invalid response. Try again later.

The message on a JSON response missing the update data will now be:

Update check failed. The server sent an invalid JSON response. Try again later.

Closes #6695

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 8, 2016

👍

@zcbenz zcbenz merged commit fd461cd into master Aug 8, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3782982 succeeded in 48s
Details
electron-linux-ia32 Build #3782983 succeeded in 44s
Details
electron-linux-x64 Build #3782984 succeeded in 82s
Details
electron-mas-x64 Build #2114 succeeded in 7 min 20 sec
Details
electron-osx-x64 Build #2112 succeeded in 6 min 36 sec
Details
electron-win-ia32 Build #1136 succeeded in 6 min 5 sec
Details
electron-win-x64 Build #1119 succeeded in 6 min 29 sec
Details

@zcbenz zcbenz deleted the recovery-suggestion branch Aug 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment