New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scroll conflict #6754

Merged
merged 1 commit into from Aug 8, 2016

Conversation

Projects
None yet
4 participants
@darkdh
Contributor

darkdh commented Aug 6, 2016

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 8, 2016

👍

@zcbenz zcbenz merged commit d1b9d03 into electron:master Aug 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@blueoctopus

This comment has been minimized.

blueoctopus commented Aug 16, 2016

v1.3.3 broke the detection of the scroll-touch-begin and scroll-touch-end events for me within a webview. This seems to be the fix that caused this issue. v1.3.2 works as expected.

Behavior that I'm observing on v1.3.3:

  • Most of the time, the scroll-touch-* events are not emitted when the cursor is on top of a webview.
  • The scroll-touch-* events seem to be emitted only once when the cursor is on a webview and on a scrollable element. The scrollable elements in my app have no native scrollbar set (they have the style overflow: hidden; set instead of overflow: scroll;). This is the case in which I need to receive the scroll-touch-* events.
  • The scroll-touch-* events seem to work fine when the cursor is outside of the webview tag.
@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Aug 16, 2016

@blueoctopus would you mind opening a new issue with the details?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment