New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report app.setUserTasks success/failure #6766

Merged
merged 2 commits into from Aug 8, 2016

Conversation

Projects
None yet
3 participants
@miniak
Contributor

miniak commented Aug 7, 2016

Changes return value of Browser::SetUserTasks from void to bool

@@ -156,7 +156,7 @@ class Browser : public WindowListObserver {
};
// Add a custom task to jump list.
void SetUserTasks(const std::vector<UserTask>& tasks);
bool SetUserTasks(const std::vector<UserTask>& tasks);

This comment has been minimized.

@kevinsawicki

kevinsawicki Aug 7, 2016

Contributor

Can you also update the docs to mention this method now returns whether it was successful? Thanks.

https://github.com/electron/electron/blob/master/docs/api/app.md#appsetusertaskstasks-windows

This comment has been minimized.

@miniak

miniak Aug 8, 2016

Contributor

done

This comment has been minimized.

@miniak

miniak Aug 8, 2016

Contributor

I have also noticed that both app.setAsDefaultProtocolClient(protocol) and app.removeAsDefaultProtocolClient(protocol) return a boolean, I've updated the docs.

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 8, 2016

👍

@zcbenz zcbenz merged commit a432fb0 into electron:master Aug 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@miniak miniak deleted the miniak:set-user-tasks-result branch Aug 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment