New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HasRealNamedCallbackProperty check when converting objects #6776

Merged
merged 3 commits into from Aug 9, 2016

Conversation

Projects
None yet
2 participants
@kevinsawicki
Contributor

kevinsawicki commented Aug 8, 2016

This pull request removes the HasRealNamedCallbackProperty check from V8ValueConverter::FromV8Object.

It looks like Chrome removed this check in https://codereview.chromium.org/16511004 so it seems safe to remove in Electron.

Original issue was https://bugs.chromium.org/p/chromium/issues/detail?id=139933 which was fixed and tweaked a couple times.

This allows objects like document.location to have their properties send over IPC.

Closes #6407

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Aug 8, 2016

@MarshallOfSound Thanks a ton for investigating this issue further and updating the original issue with your findings 👍

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Aug 9, 2016

👍

@zcbenz zcbenz merged commit 25f29e3 into master Aug 9, 2016

8 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-linux-arm Build #3794276 succeeded in 47s
Details
electron-linux-ia32 Build #3794277 succeeded in 43s
Details
electron-linux-x64 Build #3794278 succeeded in 81s
Details
electron-mas-x64 Build #2143 succeeded in 7 min 23 sec
Details
electron-osx-x64 Build #2139 succeeded in 7 min 1 sec
Details
electron-win-ia32 Build #1163 succeeded in 6 min 13 sec
Details
electron-win-x64 Build #1147 succeeded in 6 min 31 sec
Details

@zcbenz zcbenz deleted the remove-has-real-name-callback-property-check branch Aug 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment